-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust mapbox access token usage #1150
Conversation
// React Native Config | ||
resValue "string", "build_config_package", "com.mapeo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following the step described here: https://github.com/lugg/react-native-config?tab=readme-ov-file#advanced-android-setup
Hoping I read it correctly and did the right thing, but not entirely sure tbh. Figured it was a relevant step because we do specify different suffixes depending on the build and command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this step i skipped when I tried this library earlier. So this must be necesssary...
I did a manual build in bitrise to test the use of the secret key and everything seems to be working: https://app.bitrise.io/build/5ee6fbee-1cb2-4924-9eaa-8b06619035c4?tab=artifacts |
@gmaclennan Im currently using a token from my personal account. Were you thinking that we just use a free token from the Digidem account, or did you have something else in mind? |
Updated the token (to the digidem account token) in bitrise, and the reference to the encrypted token in the cirrus.yml |
FYI |
this was done at my suggestion to make it slightly easier for local development by taking advantage of our usage of https://babeljs.io/docs/babel-plugin-transform-inline-environment-variables (being used for feature flagging). can revert it and instead update the docs to say that an |
This reverts commit ffe572a.
Ah great, didn't realise we used that in comapeo. We could have skipped adding react-native-config 😀 |
I don't think its working for .env files. It seems like it is only picking up shell env variables. So react-native-config is still needed. There was some work we could have done to update babel and make it work, but that lead to a whole slew of other updating issues |
yeah unfortunately it would be a little inconvenient to only rely on this for local development as you have to specify/export the environment variable in the shell for the command that eventually runs |
decided to revert the change introducing |
react-native-config
to read a.env
file containing the token of interestcontributing.md
to reflect use of env file