Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: basic test that uses IPC #945

Merged
merged 2 commits into from
Dec 17, 2024
Merged

test: basic test that uses IPC #945

merged 2 commits into from
Dec 17, 2024

Conversation

EvanHahn
Copy link
Contributor

CoMapeo Mobile doesn't use MapeoManager directly; it uses an IPC bridge.

This adds a test that creates a manager in a separate process and uses @comapeo/ipc to test it.

This is something we've been discussing for awhile, and this finally implements it. I think this is useful on its own but also makes a future change easier.

@EvanHahn EvanHahn requested a review from gmaclennan October 29, 2024 19:22
@awana-lockfile-bot
Copy link

awana-lockfile-bot bot commented Oct 29, 2024

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
@comapeo/core UPDATED 2.1.0 2.3.0
@comapeo/ipc ADDED - 2.1.0
@msgpack/msgpack ADDED - 1.12.2
@sinclair/typebox UPDATED 0.29.6 0.33.22
const-max-uint32 ADDED - 1.0.2
length-prefixed-stream ADDED - 2.0.0
rpc-reflector ADDED - 1.3.11
serialize-error ADDED - 8.1.0
through2 ADDED - 4.0.2
validate.io-array-like ADDED - 1.0.2
validate.io-integer-primitive ADDED - 1.0.0
validate.io-number-primitive ADDED - 1.0.0

@EvanHahn EvanHahn marked this pull request as draft October 29, 2024 20:27
@EvanHahn EvanHahn marked this pull request as ready for review October 29, 2024 20:35
CoMapeo Mobile doesn't use `MapeoManager` directly; it uses an IPC
bridge.

This adds a test that creates a manager in a separate process and uses
`@comapeo/ipc` to test it.

This is something we've been discussing for awhile, and this finally
implements it. I think this is useful on its own but also makes a
future change easier.
@EvanHahn EvanHahn enabled auto-merge (squash) December 12, 2024 16:56
@EvanHahn EvanHahn disabled auto-merge December 12, 2024 16:56
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good apart from a minor nitpick about the name "forked-process". My understanding that this is running a worker thread, which is different from a forked process. But fine to merge as-is!

@EvanHahn
Copy link
Contributor Author

Renamed in cc6b1b7.

@EvanHahn EvanHahn merged commit e7955a8 into main Dec 17, 2024
8 of 9 checks passed
@EvanHahn EvanHahn deleted the ipc-tests branch December 17, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants