Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix DataType.getByDocId implementation to match type definition #317

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Oct 4, 2023

Closes #301

Decided to go with throwing an error if not found since

  1. all of the existing code that uses this method is written based on that type definition.
  2. it aligns more closely with the client docs i had spec'd a while ago

Not a huge fan of it, as explained in #301 (comment), but this approach requires the smallest amount of changes and is fine for now

@achou11 achou11 requested a review from gmaclennan October 4, 2023 18:51
@achou11 achou11 force-pushed the 301/datatype-docbyid-fix branch from f651163 to ed8d961 Compare October 4, 2023 18:52
@achou11 achou11 force-pushed the 301/datatype-docbyid-fix branch from ed8d961 to 9d776a7 Compare October 4, 2023 20:51
@achou11 achou11 merged commit 015ee08 into main Oct 4, 2023
6 checks passed
@achou11 achou11 deleted the 301/datatype-docbyid-fix branch October 4, 2023 20:54
gmaclennan added a commit that referenced this pull request Oct 5, 2023
* main:
  chore: remove ipc wrapper implementation (#306)
  fix: fix DataType.getByDocId implementation to match type definition (#317)
  chore: Add CI release workflow (#300)
  Feat: Icon data type (#304)
  chore: emit peer-have messages, don't persist them (#310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect return type for DataType.getByDocId() method
2 participants