Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve error handling #121

Merged
merged 8 commits into from
Sep 18, 2023

Conversation

mattdean-digicatapult
Copy link
Contributor

Honestly there are so many changes here it's hard to list but I'll try:

  1. Massively improved the use of zod to cover all manor of error cases. I probably need more tests here to demonstrate but it now uses zod to catch multiple restriction keys, invalid name lengths and various other things
  2. fixed list so it actually lists things out to the console
  3. individual process results are listed separately with success fail

@mattdean-digicatapult mattdean-digicatapult marked this pull request as ready for review September 14, 2023 14:41
n3op2
n3op2 previously approved these changes Sep 18, 2023
Copy link
Contributor

@n3op2 n3op2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

src/lib/process/_tests_/unit.test.ts Show resolved Hide resolved
src/lib/process/api.ts Show resolved Hide resolved
src/lib/process/index.ts Show resolved Hide resolved
src/lib/types/validation.ts Outdated Show resolved Hide resolved
src/lib/types/validation.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants