Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbosity to the command line #112

Merged
merged 30 commits into from
Sep 8, 2023
Merged

Add verbosity to the command line #112

merged 30 commits into from
Sep 8, 2023

Conversation

nitro-marky
Copy link
Contributor

@nitro-marky nitro-marky commented Aug 31, 2023

Add a verbosity flag if you want to print all the information.

It's can be run like this npm run local list -- --verbose

Without the verbose flag

{ id: 'process-1', version: 2, status: 'Enabled' }, { id: 'process-1', version: 1, status: 'Enabled' }, { id: 'test-program-propose', version: 1, status: 'Enabled' }, { id: 'process-2', version: 2, status: 'Enabled' }, { id: 'process-2', version: 1, status: 'Enabled' },

with verbose flag

id: 'process-1', version: 2, status: 'Enabled', program: [ { restriction: { senderHasInputRole: { index: 0, roleKey: 'Supplier' } } } ] }, { id: 'process-1', version: 1, status: 'Enabled', program: [ { restriction: { senderHasInputRole: { index: 0, roleKey: 'Supplier' } } } ] }, { id: 'test-program-propose', version: 1, status: 'Enabled', program: [ { restriction: { fixedNumberOfInputs: { numInputs: 2 } } }, { restriction: { fixedNumberOfOutputs: { numOutputs: 3 } } }, { op: 'And' }, { restriction: { fixedInputMetadataValue: { index: 0, metadataKey: '0x74797065', metadataValue: { literal: '0x44454d414e44' } } } }, { op: 'And' },


Todo in another PR:

  • Unit testing on the verbose additions

@nitro-marky nitro-marky marked this pull request as ready for review August 31, 2023 14:43
Copy link
Contributor

@dblane-digicatapult dblane-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the first of several PRs for this L3-138?

@nitro-marky
Copy link
Contributor Author

nitro-marky commented Sep 4, 2023

Is this the first of several PRs for this L3-138?

@n3op2 said this is a good place to start

@nitro-marky
Copy link
Contributor Author

nitro-marky commented Sep 4, 2023

Is this the first of several PRs for this L3-138?

Am I right in thinking you mean add one for create?

src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@n3op2 n3op2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we are getting there

src/index.ts Show resolved Hide resolved
src/lib/process/api.ts Outdated Show resolved Hide resolved
tests/integration/command-functions.test.ts Outdated Show resolved Hide resolved
tests/integration/command-functions.test.ts Show resolved Hide resolved
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once @n3op2 is happy I'm happy

@nitro-marky nitro-marky merged commit 47f00f8 into main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants