Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise deps into workspace #152

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

mattdean-digicatapult
Copy link
Contributor

Re-organises our dpeendencies into the workspace Cargo.toml so that we can refer to consistent versions everywhere. This should make it easier for us to upgrade dependencies (especially substrate deps) in the future.

Note this doesn't upgrade any dependencies or change nay code other than some package renames. Hence no benchmark updates

Copy link

This PR updates the following pallets - they may also require updates to their extrinsic weights:
process-validation symmetric-key utxo-nft

For the author and any reviewers:

  • consider whether the changes could significantly affect the weight of any extrinsics
  • consider whether benchmarks need updating to correctly cover weight variations over inputs

For a guide on running benchmarks to update weights see calculating weights

@mattdean-digicatapult mattdean-digicatapult merged commit 641ed27 into main Dec 19, 2023
8 checks passed
@mattdean-digicatapult mattdean-digicatapult deleted the chore/reorganise-deps branch December 19, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants