Add option to enable manual sealing of blocks when in dev mode #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdean-digicatapult
requested review from
jonmattgray and
n3op2
as code owners
n3op2
approved these changes
Dec 18, 2023
dblane-digicatapult
requested changes
Dec 18, 2023
I honestly don't see how @dblane-digicatapult without adding some substantial apparatus to the node. Given we don't test any of the rest of the CLI this doesn't seem like a regression. |
dblane-digicatapult
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running integration tests on repositories that depend on
dscp-nodewe have to limit tests that interact with the chain because of the 6s block generation time. This PR enables a--manual_sealoption when running with--devthat will allow us to manually trigger block generation and finalisation usng an RPC command. This should make it much more practical for us to have an extensive suite of integration tests.