Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L3 231/add production monitoring #80

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

msterle
Copy link
Contributor

@msterle msterle commented Apr 22, 2024

PR 2/2 For L3-231

This PR adds the monitoring stack defined for the kind cluster to the production cluster. It also adds the service monitors for the other components.

Copy link
Contributor

@dblane-digicatapult dblane-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but we need to look a bit more closely at what SC's we should use for data and the retention of it long-term.

enabled: true
ingressClassResource:
name: nginx
default: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably set this one to be the default.

clusters/l3-sqnc/monitoring/release.yaml Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere in here there should be entries related to the ingress and ingressClass we are using. As well as how we expose both prometheus and grafana dashboards.

Comment on lines +36 to +37
persistence:
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be setting the strorageclass and check that the default size of the PVC is sufficient for our needs.

Comment on lines 18 to 19
prometheusSpec:
retention: 24h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retention is way too long for production. @mattdean-digicatapult thoughts on how long we want to keep stuff?

Comment on lines 14 to 23
prometheus:
serviceMonitor:
selfMonitor: true
namespace: monitoring
prometheusSpec:
retention: 24h
resources:
requests:
cpu: 200m
memory: 200Mi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set a persistence option here, as well as potentially have these pods autoscaling. Those default resources look a bit minuscule for a production cluster so we should beef this up somewhat.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running horizontal scaling on prometheus is a mess. It can be configured by using thanos in this chart, but that is a lot of overhead for our needs ATM.

Instead I've set it up as HA, with vertical scaling on the prometheus instances.

clusters/l3-sqnc/monitoring/values.yaml Outdated Show resolved Hide resolved
@msterle
Copy link
Contributor Author

msterle commented Apr 24, 2024

All the resource requirements for the monitoring stack are best guesses. We'd probably have to fine-tune this according to actual usage.

@msterle msterle marked this pull request as ready for review April 25, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants