Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add storybook vercel github action #888

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

Thunear
Copy link
Collaborator

@Thunear Thunear commented Oct 2, 2023

Add a github action for storybook vercel deployment so we can test it on storybook.designsystemet.no when DNS is ready.
Then we can replace storybook-deploy.yml with this when we are happy (remove action for gh-pages).

This action is identical to the storybook preview action except I:

  • Changed to trigger on main changes
  • Remove if checks
  • Changed environment to production
  • Removed comment to PR feature

@Thunear Thunear self-assigned this Oct 2, 2023
@Thunear Thunear marked this pull request as ready for review October 2, 2023 16:41
@Thunear Thunear requested a review from mimarz October 3, 2023 13:32
@Thunear Thunear mentioned this pull request Oct 3, 2023
3 tasks
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Thunear Thunear merged commit 84a29cf into main Oct 3, 2023
1 check passed
@Thunear Thunear deleted the chore/vercel-storybook-hosting branch October 3, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants