Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Fieldset, Switch, Radio, Checkbox): ✨ Add large size #841

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Sep 21, 2023

Added support for large size to Fieldset and useFormField which are the basis for our form components.

This means that Switch, Radio, Checkboxwill now also have large size.

@TomasEng
Copy link
Contributor

Kunne vi hatt en felles type for disse størrelsene? Det er jo det samme overalt.

@mimarz
Copy link
Collaborator Author

mimarz commented Sep 21, 2023

Kunne vi hatt en felles type for disse størrelsene? Det er jo det samme overalt.

useFormField er vel fellesnevneren her som er tanken at alle skal bruke den. Nesten alle komponentene bruker den forutenom Fieldset for å unngå circular dependency. Skal se om jeg ikke kan rydde opp mellom contextene 🤔

@mrosvik
Copy link
Member

mrosvik commented Sep 21, 2023

LGTM! 💫

@mimarz
Copy link
Collaborator Author

mimarz commented Sep 21, 2023

Kunne vi hatt en felles type for disse størrelsene? Det er jo det samme overalt.

useFormField er vel fellesnevneren her som er tanken at alle skal bruke den. Nesten alle komponentene bruker den forutenom Fieldset for å unngå circular dependency. Skal se om jeg ikke kan rydde opp mellom contextene 🤔

Var allerede en circular dependency mellom Fieldset og useFormField så bare la til den type der og, skiller med import type statement, så burde være i orden 😅

@mimarz mimarz merged commit 4e8052f into main Sep 21, 2023
2 checks passed
@mimarz mimarz deleted the feat/fielset-large branch September 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants