Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storefront): add CSS tokens and clean code for layouts #796

Merged
merged 16 commits into from
Sep 25, 2023

Conversation

Thunear
Copy link
Collaborator

@Thunear Thunear commented Sep 7, 2023

Resolves: #792

  • Go through the layouts and assign CSS variables and clean CSS order.
  • Go through the layouts and clean code.
    • Utilize the as prop to combine Link and NextLink where it is used
  • Changed to using React components for the frontpageLayout to make it more modular for the future.
  • Cleaned the MDXContent component because it is so closely connected to the layouts.
  • Moved all typography styling for the layouts into the MDXContent component.
  • Fixed an issue where the custom <head> wasn´t beeing rendered in the NotFoundLayout. Had to execute the content function in layout.

@Thunear Thunear self-assigned this Sep 7, 2023
@Thunear Thunear added the 🖥️ storefront designsystemet.no label Sep 7, 2023
@Thunear Thunear changed the title chore(storefront): add CSS tokens and clean layouts chore(storefront): add CSS tokens and clean code for layouts Sep 7, 2023
@Thunear Thunear marked this pull request as ready for review September 14, 2023 07:34
@github-actions
Copy link
Contributor

Storefront preview deployment is available at https://storefront-b08xvn3zn-designsystemet.vercel.app

@mimarz
Copy link
Collaborator

mimarz commented Sep 20, 2023

@Thuneer Suggest resolving the merge conflict :)

@Thunear
Copy link
Collaborator Author

Thunear commented Sep 25, 2023

@Thuneer Suggest resolving the merge conflict :)

Done! :D

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is so much stuff here, but I guess it looks good. Works atleast! 😅

@Thunear Thunear merged commit cf8343a into main Sep 25, 2023
2 checks passed
@Thunear Thunear deleted the chore/storefront-clean-layouts branch September 25, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥️ storefront designsystemet.no
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storefront: Clean layouts
2 participants