-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storefront): add CSS tokens and clean code for layouts #796
Merged
+220
−449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thunear
changed the title
chore(storefront): add CSS tokens and clean layouts
chore(storefront): add CSS tokens and clean code for layouts
Sep 7, 2023
Thunear
requested review from
mimarz,
TomasEng,
framitdavid and
Magnusrm
as code owners
September 14, 2023 07:34
Storefront preview deployment is available at https://storefront-b08xvn3zn-designsystemet.vercel.app |
@Thuneer Suggest resolving the merge conflict :) |
…igdir/designsystem into chore/storefront-clean-layouts
Done! :D |
mimarz
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is so much stuff here, but I guess it looks good. Works atleast! 😅
Magnusrm
pushed a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #792
as
prop to combine Link and NextLink where it is usedMDXContent
component because it is so closely connected to the layouts.MDXContent
component.<head>
wasn´t beeing rendered in theNotFoundLayout
. Had to execute the content function in layout.