Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve token preview in storefront #665

Merged
merged 39 commits into from
Sep 18, 2023
Merged

chore: improve token preview in storefront #665

merged 39 commits into from
Sep 18, 2023

Conversation

Thunear
Copy link
Collaborator

@Thunear Thunear commented Jul 11, 2023 •
edited by mimarz
Loading

  • Look at improving the presentation of the tokens in the storefront. The way it is presented at the moment with a long list of tokens is not very user friendly.
  • Make the token preview dynamic, so that new versions of the tokens package automatically syncs with the previews.

Proposed change:
image

Edited by @mimarz :

resolves #697

@Thunear Thunear mentioned this pull request Aug 10, 2023
Closed
@Thunear Thunear added 📔 storybook storybook.designsystemet.no 🖥️ storefront designsystemet.no and removed 📔 storybook storybook.designsystemet.no 🖥️ storefront designsystemet.no labels Aug 28, 2023
@mimarz mimarz mentioned this pull request Sep 7, 2023
Closed
@Thunear Thunear marked this pull request as ready for review September 8, 2023 06:42
@mimarz mimarz added the 🖥️ storefront designsystemet.no label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Storefront preview deployment is available at https://storefront-gz5bz30ur-designsystemet.vercel.app

@Thunear Thunear marked this pull request as draft September 8, 2023 09:49
@Thunear Thunear self-assigned this Sep 8, 2023
@github-actions
Copy link
Contributor

Storefront preview deployment is available at https://storefront-rjnj03f31-designsystemet.vercel.app

@github-actions
Copy link
Contributor

Storefront preview deployment is available at https://storefront-mymdab0ht-designsystemet.vercel.app

@mimarz mimarz marked this pull request as ready for review September 13, 2023 08:59
@mimarz mimarz requested a review from Magnusrm as a code owner September 13, 2023 08:59
@github-actions
Copy link
Contributor

Storefront preview deployment is available at https://storefront-72o66b20j-designsystemet.vercel.app

@mrosvik
Copy link
Member

mrosvik commented Sep 18, 2023

Ser bra ut! :D

mimarz
mimarz approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Marianne is happy, I am happy!

@mimarz mimarz merged commit 00d9639 into main Sep 18, 2023
3 checks passed
@mimarz mimarz deleted the chore/storefront-better-preview branch September 18, 2023 08:08
Magnusrm pushed a commit that referenced this pull request Sep 27, 2023
@Thunear @mimarz @Magnusrm
chore: improve token preview in storefront (#665)
262c10d 
Co-authored-by: Michael Marszalek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@TomasEng TomasEng Awaiting requested review from TomasEng

@framitdavid framitdavid Awaiting requested review from framitdavid

@Magnusrm Magnusrm Awaiting requested review from Magnusrm

Assignees

@Thunear Thunear

Labels
🖥️ storefront designsystemet.no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve token preview for storefront
3 participants
@Thunear @mrosvik @mimarz