fix(Pagination): use empty li for ellipsis #2942
Open
+68
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 76d830d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Barsnes
reviewed
Jan 6, 2025
mimarz
reviewed
Jan 6, 2025
mimarz
reviewed
Jan 6, 2025
| @@ -64,13 +64,13 @@ export const usePagination = ({ | |||
| (page, index) => ({ | |||
| page: page || '', | |||
There was a problem hiding this comment.
Why not just mark it explicit as ellipsis if its an ellipsis?
Suggested change
| page: page || '', | |
| page || 'ellipsis', |
There was a problem hiding this comment.
Can be now that we type check typeof page === 'number'
mimarz
approved these changes
Jan 6, 2025
|
We should also make a return type for |
We should probably make a page for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lifor ellipsis