Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove spacing and sizing design-tokens #2939

Open
wants to merge 20 commits into
base: next
Choose a base branch
from
Open

chore: remove spacing and sizing design-tokens #2939

wants to merge 20 commits into from
+9,756 −10,767

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Jan 2, 2025

resolves #2938

Replaced by size design-token.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 18de2a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-theme Minor
@digdir/designsystemet-css Minor
@digdir/designsystemet Minor
@digdir/designsystemet-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Preview deployments for this pull request:

Storybook - 7. Jan 2025 - 12:22

Storefront - 7. Jan 2025 - 12:23

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.13% 3197 / 5799
🔵 Statements 55.13% 3197 / 5799
🔵 Functions 85.84% 182 / 212
🔵 Branches 77.17% 524 / 679
File CoverageNo changed files found.
Generated in workflow #1472 for commit 18de2a3 by the Vitest Coverage Report Action

@mimarz mimarz mentioned this pull request Jan 2, 2025
Merged
@mimarz mimarz force-pushed the feat-remove-spacing-and-sizing-design-tokens branch 4 times, most recently from 8e0fbd8 to 6d4ff30 Compare January 6, 2025 09:12
@mimarz mimarz marked this pull request as ready for review January 6, 2025 10:42
Barsnes
Barsnes requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tokenlist on the storefront does not seem to display the px value correctly
image

@Barsnes
Copy link
Member

Barsnes commented Jan 6, 2025

The tokenlist on the storefront does not seem to display the px value correctly image

To fix this, I believe you have to do value + 'rem' on line 63 in TokenList

@mimarz
Copy link
Collaborator Author

mimarz commented Jan 6, 2025

The tokenlist on the storefront does not seem to display the px value correctly image

To fix this, I believe you have to do value + 'rem' on line 63 in TokenList

Thanks, forgot to fix this :)

@mimarz mimarz requested a review from Barsnes January 7, 2025 11:18
@mimarz mimarz force-pushed the feat-remove-spacing-and-sizing-design-tokens branch from 00f9734 to 18de2a3 Compare January 7, 2025 11:20
Barsnes
Barsnes reviewed Jan 7, 2025
View reviewed changes
apps/storefront/components/Tokens/TokenList/TokenList.tsx
<Table.HeaderCell>Rem</Table.HeaderCell>
<Table.HeaderCell>Px (16px)</Table.HeaderCell>
<Table.HeaderCell>Verdi</Table.HeaderCell>
<Table.HeaderCell>Reel verdi</Table.HeaderCell>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Table.HeaderCell>Reel verdi</Table.HeaderCell>
<Table.HeaderCell>Reell verdi</Table.HeaderCell>

apps/storefront/components/Tokens/TokenList/TokenList.tsx
/>
</Table.Cell>
<Table.Cell>{token.$value}</Table.Cell>
<Table.Cell>{value} </Table.Cell>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Table.Cell>{value} </Table.Cell>
<Table.Cell>{value}</Table.Cell>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barsnes Barsnes Barsnes requested changes

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@unekinn unekinn Awaiting requested review from unekinn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename sizing design-tokens
2 participants
@mimarz @Barsnes