Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Field): cleanup stories and position prop #2931

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

eirikbacker
Copy link
Contributor

  • Docs: clean up stories
  • Fix: use position prop in data-position

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Preview deployments for this pull request:

Storybook - 3. Jan 2025 - 10:46

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.13% 3197 / 5799
🔵 Statements 55.13% 3197 / 5799
🔵 Functions 85.84% 182 / 212
🔵 Branches 77.17% 524 / 679
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/Field/Field.tsx 100% 100% 100% 100%
Generated in workflow #1413 for commit 3934671 by the Vitest Coverage Report Action

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changeset for fix of position. Changeset bot, did you go on christmas holdiday? 🎅

Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: 3934671

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mimarz mimarz merged commit c500f47 into next Jan 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants