Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): add width auto option #2894

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix(Select): add width auto option #2894

merged 3 commits into from
Dec 13, 2024

Conversation

eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Dec 13, 2024

  • As discussed https://designsystemet.slack.com/archives/C05U1MNKYCX/p1733498017147069
  • <Select> follows the width of its widest content, but <Input> is automatically full width unless size is set
  • To make this consistent, we make <Select> automatically full width, unless setting data-width="auto"
  • We're using data-width="auto" to avoid conflict with native <select multiselect size="3"> and data-size styling

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: c32f6dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-css Patch
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Preview deployments for this pull request:

Storybook - 13. Dec 2024 - 13:38

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.26% 3194 / 5779
🔵 Statements 55.26% 3194 / 5779
🔵 Functions 87.08% 182 / 209
🔵 Branches 76.88% 519 / 675
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/Select/Select.tsx 81.81% 50% 66.66% 81.81% 30-33
Generated in workflow #1275 for commit c32f6dd by the Vitest Coverage Report Action

Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure to add a short text in the PR description about why we do this, The slack message is not visible to everyone

Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Dismiss my approval, seems like this causes unwanted side effects

@eirikbacker
Copy link
Contributor Author

Looks good, but make sure to add a short text in the PR description about why we do this, The slack message is not visible to everyone

Good point!

@eirikbacker
Copy link
Contributor Author

image Dismiss my approval, seems like this causes unwanted side effects

Nice, pushet men måtte løpe før jeg rakk å se på chromatic - det er så nice vi har den! har fikset det issuet nuh ☺️

@eirikbacker eirikbacker requested a review from Barsnes December 13, 2024 12:43
@mimarz mimarz merged commit 23450ce into next Dec 13, 2024
10 checks passed
@mimarz mimarz deleted the fix/select-width-auto branch December 13, 2024 13:48
mimarz pushed a commit that referenced this pull request Dec 13, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Minor Changes

- Added option dry run using `--dry` on `tokens create` & `tokens build`
([#2884](#2884))

- `tokens create` now writes by default
([#2884](#2884))

- Changed `-w, --write` to `-o, --out-dir` on `tokens create` & `tokens
build` for defining output dir
([#2884](#2884))

## @digdir/[email protected]

### Patch Changes

- Remove `neutral` color on `ValidationMessage`
([#2895](#2895))

- Added styling for Windows High Contrast mode and
[forced-colors](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/forced-colors)
([#2876](#2876))

- Badge: Convert to two elements, add `Badge.Position` component for
placement ([#2857](#2857))

- Select: Add `width="auto"` option and default to full width
([#2894](#2894))

## @digdir/[email protected]

### Patch Changes

- Radio, Checkbox: Spread `className` and `style` on outermost element
([#2880](#2880))

- Badge: Convert to two elements, add `Badge.Position` component for
placement ([#2857](#2857))

- `ValidationMessage` now uses the `p`-element
([#2895](#2895))

- Select: Add `width="auto"` option and default to full width
([#2894](#2894))

## @digdir/[email protected]

### Patch Changes

- Tweaked color codes. Visually remains the same
([#2854](#2854))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants