-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Select): add width auto option #2894
Conversation
🦋 Changeset detectedLatest commit: c32f6dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but make sure to add a short text in the PR description about why we do this, The slack message is not visible to everyone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/[email protected] ### Minor Changes - Added option dry run using `--dry` on `tokens create` & `tokens build` ([#2884](#2884)) - `tokens create` now writes by default ([#2884](#2884)) - Changed `-w, --write` to `-o, --out-dir` on `tokens create` & `tokens build` for defining output dir ([#2884](#2884)) ## @digdir/[email protected] ### Patch Changes - Remove `neutral` color on `ValidationMessage` ([#2895](#2895)) - Added styling for Windows High Contrast mode and [forced-colors](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/forced-colors) ([#2876](#2876)) - Badge: Convert to two elements, add `Badge.Position` component for placement ([#2857](#2857)) - Select: Add `width="auto"` option and default to full width ([#2894](#2894)) ## @digdir/[email protected] ### Patch Changes - Radio, Checkbox: Spread `className` and `style` on outermost element ([#2880](#2880)) - Badge: Convert to two elements, add `Badge.Position` component for placement ([#2857](#2857)) - `ValidationMessage` now uses the `p`-element ([#2895](#2895)) - Select: Add `width="auto"` option and default to full width ([#2894](#2894)) ## @digdir/[email protected] ### Patch Changes - Tweaked color codes. Visually remains the same ([#2854](#2854)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
<Select>
follows the width of its widest content, but<Input>
is automatically full width unlesssize
is set<Select>
automatically full width, unless settingdata-width="auto"
data-width="auto"
to avoid conflict with native<select multiselect size="3">
anddata-size
styling