Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to React 19 #2862

Draft
wants to merge 11 commits into
base: next
Choose a base branch
from
Draft

chore: upgrade to React 19 #2862

wants to merge 11 commits into from

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Dec 5, 2024

Test just upgrade without making use of new features yet, so we can get new types and other improvements.

Test downstream what still works or don't.

Published under the test tag for @digdir/designsystemet-react

@digdir/designsystemet-react@test

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 0c07942

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-react Minor
@digdir/designsystemet Minor
@digdir/designsystemet-css Minor
@digdir/designsystemet-theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Preview deployments for this pull request:

Storybook - 10. Dec 2024 - 15:21

Storefront - 10. Dec 2024 - 15:22

Theme - 10. Dec 2024 - 15:22

@Barsnes Barsnes changed the title chore: Upgrade to React 19 chore: upgrade to React 19 Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 54.76% 3146 / 5745
🔵 Statements 54.76% 3146 / 5745
🔵 Functions 86.95% 180 / 207
🔵 Branches 76.88% 509 / 662
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/Modal/ModalTriggerContext.tsx 100% 100% 100% 100%
packages/react/src/components/form/Combobox/Combobox.tsx 88.46% 65.95% 71.42% 88.46% 163-164, 213-216, 258-259, 267, 276-277, 324-325, 433-457, 461-464
packages/react/src/components/form/Combobox/ComboboxContext.tsx 100% 100% 100% 100%
packages/react/src/components/form/Combobox/Option/useComboboxOption.tsx 93.1% 75% 100% 93.1% 37-38, 60-61
packages/react/src/utilities/RovingFocus/RovingFocusRoot.tsx 93.1% 68.18% 42.85% 93.1% 52, 55, 112-113, 132, 134
packages/react/src/utilities/hooks/useCheckboxGroup/useCheckboxGroup.ts 100% 90.69% 100% 100%
packages/react/src/utilities/hooks/useRadioGroup/useRadioGroup.ts 100% 90.47% 100% 100%
Generated in workflow #1222 for commit 0c07942 by the Vitest Coverage Report Action

@mimarz mimarz force-pushed the chore-upgrade-react19 branch from cc18bba to 8ea0e0b Compare December 10, 2024 13:42
@mimarz
Copy link
Collaborator Author

mimarz commented Dec 10, 2024

Seems to work fine on demo app in https://github.com/mimarz/designsystemet-demo but its pretty basic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants