Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: storefront fixes #2844

Merged
merged 7 commits into from
Nov 28, 2024
Merged

chore: storefront fixes #2844

merged 7 commits into from
Nov 28, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Nov 28, 2024 •
edited
Loading

This PR ports over changes and fixes from #2830
resolves #2840
resolves #2816

New codeblock styling is approved by @Thunear

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0fd64d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

Preview deployments for this pull request:

Storefront - 28. Nov 2024 - 10:22

Theme - 28. Nov 2024 - 10:22

@Barsnes Barsnes marked this pull request as ready for review November 28, 2024 08:11
@Barsnes Barsnes changed the title chore: storefront fix chore: storefront fixes Nov 28, 2024
@Barsnes Barsnes marked this pull request as draft November 28, 2024 08:40
@Barsnes Barsnes marked this pull request as ready for review November 28, 2024 08:58
@Barsnes Barsnes merged commit e9aaa40 into next Nov 28, 2024
7 checks passed
@Barsnes Barsnes deleted the storefront/build-errors branch November 28, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@unekinn unekinn Awaiting requested review from unekinn unekinn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NaN in table in spacing documentation Typo in grunnleggende/designelementer/farger
2 participants
@Barsnes @mimarz