feat: rename size prop to data-size
#2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Preview deployments for this pull request: Storybook - Storefront - Theme - |
mimarz
reviewed
Oct 25, 2024
mimarz
reviewed
Oct 25, 2024
mimarz
reviewed
Oct 25, 2024
mimarz
reviewed
Oct 25, 2024
mimarz
reviewed
Oct 25, 2024
mimarz
reviewed
Oct 25, 2024
packages/react/src/components/ToggleGroup/ToggleGroup.stories.tsx
Outdated
Show resolved
Hide resolved
mimarz
reviewed
Oct 25, 2024
| <Pagination.Item key={itemKey}> | ||
| <Pagination.Button {...buttonProps} aria-label={`Side ${page}`}> | ||
| {page} | ||
| {sizes.map((size) => ( |
There was a problem hiding this comment.
Cant you just use one map here and return components in a fragment or array? Thats quite a lot of maps...
There was a problem hiding this comment.
Thats what I originally did, but due to us wanting the same component on the x-axis in the grid, we need to have a map for each component, that way it lands in the same grid-column
mimarz
approved these changes
Oct 25, 2024
Barsnes
added a commit
that referenced
this pull request
Oct 28, 2024
commit ce23f32 Author: Eirik Backer <[email protected]> Date: Mon Oct 28 10:31:21 2024 +0100 fix(Chip): use input component (#2683) - Fixes #2669 - Fixes wrong height implemented (now correctly `32px`) - Implements simplified states after dialogue with Marianne - Fixes better alignment of label vs. radio/checkbox - Implements logic so elements with the `ds-focus--visible` class automatically hides focus ring on children (no need for confusing, nested focus rings) commit d5e0ba1 Author: Lasse Febakke Straum <[email protected]> Date: Fri Oct 25 15:08:14 2024 +0200 refactor(tokens): changed spacing and sizing type to dimension (#2688) Co-authored-by: Tobias Barsnes <[email protected]> Co-authored-by: Michael Marszalek <[email protected]> commit 6c1f99d Author: Eirik Backer <[email protected]> Date: Fri Oct 25 13:52:51 2024 +0200 chore: remove tmp field styling in testing story (#2687) - Since field styling is now merged, `testing.stories.tsx` no longer needs to fake it commit f4f76d3 Author: Eirik Backer <[email protected]> Date: Fri Oct 25 13:41:36 2024 +0200 fix(Heading+Label+ValidationMessage): clean up css styles (#2677) Figma task is added as #2676 commit d2fc6b9 Author: Tobias Barsnes <[email protected]> Date: Fri Oct 25 13:16:17 2024 +0200 feat: rename `size` prop to `data-size` (#2680) resolves #2673 commit acef771 Author: Eirik Backer <[email protected]> Date: Fri Oct 25 10:24:19 2024 +0200 fix(Input): inherit line-height (#2685) As pointed out by hawk-eye @mimarz 💪 🙏 🦅 https://designsystemet.slack.com/archives/C07K7NEKXEW/p1729843841118129 commit d3c58b0 Author: Eirik Backer <[email protected]> Date: Fri Oct 25 10:04:16 2024 +0200 fix(Spinner): use forwardRef and aria-label for consistency (#2682) - Use `aria-label` for accessible spinner label to be consistent with other components - Use `forwardRef` on Spinner --------- Co-authored-by: Tobias Barsnes <[email protected]> commit 326671a Author: Une Sofie Kinn Ekroll <[email protected]> Date: Fri Oct 25 08:26:49 2024 +0200 feat(tokens): add modes for semantic color categories main & support (#2643) Co-authored-by: Lasse Febakke Straum <[email protected]> commit 7520547 Author: Eirik Backer <[email protected]> Date: Thu Oct 24 14:19:33 2024 +0200 fix(Radio+Checkbox): use input component (#2607) - Part of #2311 - Fieldset at compound components moved to task #2666 - Fixes #2459 commit f96289a Author: Tobias Barsnes <[email protected]> Date: Thu Oct 24 11:17:42 2024 +0200 chore: enable `noUnusedImports` biome rule (#2675) enables https://biomejs.dev/linter/rules/no-unused-imports/ commit a452813 Author: Une Sofie Kinn Ekroll <[email protected]> Date: Thu Oct 24 10:38:59 2024 +0200 feat(cli,theme): don't output underlying primitives for semantic color variables (#2641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2673