Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename error_message #2670

Merged
merged 4 commits into from
Oct 24, 2024
Merged

refactor: rename error_message #2670

merged 4 commits into from
Oct 24, 2024

Conversation

Febakke
Copy link
Member

@Febakke Febakke commented Oct 23, 2024 •
edited by mimarz
Loading

resolves #2668

Rename design token for typography; error_message -> validation-message

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 40f63a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 23. Oct 2024 - 15:50

Storefront - 23. Oct 2024 - 15:51

@mimarz mimarz marked this pull request as draft October 23, 2024 13:16
@mimarz mimarz mentioned this pull request Oct 23, 2024
Merged
@mimarz mimarz changed the title Rename error_message -> validation-message refactor: rename error_message -> validation-message Oct 23, 2024
@mimarz mimarz marked this pull request as ready for review October 23, 2024 13:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 57.94% 3647 / 6294
🔵 Statements 57.94% 3647 / 6294
🔵 Functions 84% 168 / 200
🔵 Branches 75.47% 517 / 685
File CoverageNo changed files found.
Generated in workflow #533 for commit 40f63a0 by the Vitest Coverage Report Action

@mimarz mimarz changed the title refactor: rename error_message -> validation-message refactor: rename error_message Oct 23, 2024
Barsnes
Barsnes approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should we add a changeset?

@mimarz mimarz merged commit 5336659 into next Oct 24, 2024
12 checks passed
@mimarz mimarz deleted the rename-validation_message branch October 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barsnes Barsnes Barsnes approved these changes

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@unekinn unekinn Awaiting requested review from unekinn unekinn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename error_message design token
3 participants
@Febakke @Barsnes @mimarz