Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Breadcrumbs): new component #2226

Merged
merged 16 commits into from
Aug 14, 2024
Merged

feat(Breadcrumbs): new component #2226

merged 16 commits into from
Aug 14, 2024

Conversation

eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Aug 12, 2024

@eirikbacker eirikbacker self-assigned this Aug 12, 2024
Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: 4d470b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@digdir/designsystemet-css Patch
@digdir/designsystemet-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Preview deployments for this pull request:

📖 Storybook 14. Aug 2024 - 14:54 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@eirikbacker eirikbacker marked this pull request as ready for review August 12, 2024 11:25
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just small cleanups with documentation 🚀

packages/css/breadcrumbs.css Show resolved Hide resolved
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some feedback noted.

I assume the docs are also WIP? We can also leave them sparse and update them later.

@eirikbacker eirikbacker requested review from mimarz and Barsnes August 14, 2024 07:25
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good-fine (1)

@mimarz mimarz merged commit c73d83c into next Aug 14, 2024
4 checks passed
@mimarz mimarz deleted the feat/breadcrumbs branch August 14, 2024 13:02
mimarz pushed a commit that referenced this pull request Aug 14, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Minor Changes

- feat: Convert to W3C design token format
([#2240](#2240))

### Patch Changes

- refactor: single CSS file for theme
([#2204](#2204))

- fix: Export correct types for color
([`e6325afa14e349698daf1082ba8844e80f46c5c0`](e6325af))

## @digdir/[email protected]

### Minor Changes

- Breadcrumbs: ✨ new component
([#2226](#2226))

- Badge: ✨ New component
([#2220](#2220))

### Patch Changes

- Modal: add missing ModalRoot export
([#2228](#2228))

- RovingFocus: add `orientation` to support for different arrow
directions, and add support home/end buttons
([#2206](#2206))

    -   Affects `ToggleGroup`, where up and down arrows can now be used
    -   Affects `ToggleGroup`, where home and end can now be used
    -   Affects `Tabs`, where home and end can now be used

- Accordion: Fix `defaultOpen` flicker on first render
([#2214](#2214))

- Tabs: Make arrow keys work in any direction
([#2223](#2223))

- Fixes so spacing is the same in checkbox and radio groups
([#2234](#2234))

- Divider: hide from screen readers
([#2232](#2232))

- Modal: remove `FloatingFocusManager`
([#2224](#2224))

- NativeSelect: add focus in `readOnly` state
([#2212](#2212))

## @digdir/[email protected]

### Patch Changes

- Fixes so spacing is the same in checkbox and radio groups
([#2234](#2234))

- Button: `text-align: inherit` when not in full width
([#2216](#2216))

- Breadcrumbs: ✨ new component
([#2226](#2226))

- Badge: ✨ New component
([#2220](#2220))

## @digdir/[email protected]

### Patch Changes

- refactor: single CSS file for theme
([#2204](#2204))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb: Develop React component
3 participants