Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: single CSS file for theme #2204

Merged
merged 7 commits into from
Aug 7, 2024
Merged

refactor: single CSS file for theme #2204

merged 7 commits into from
Aug 7, 2024

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Aug 6, 2024

fixes #2202
Converted the CSS file for a single to include all css generated instead of just imports for the individual files.

Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: 7f35b10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@digdir/designsystemet-theme Patch
@digdir/designsystemet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Preview deployments for this pull request:

📖 Storybook 7. Aug 2024 - 08:30 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mimarz mimarz force-pushed the fix-theme-entry-file branch from d29c497 to 7edf268 Compare August 6, 2024 11:05
@mimarz mimarz changed the title fix: Backwards compatible theme entry file fix: complete entry file Aug 6, 2024
@mimarz mimarz changed the title fix: complete entry file fix: single CSS file for theme Aug 6, 2024
@mimarz mimarz changed the title fix: single CSS file for theme refactor: single CSS file for theme Aug 6, 2024
@mimarz mimarz marked this pull request as ready for review August 6, 2024 13:17
@mimarz mimarz requested a review from Barsnes as a code owner August 6, 2024 13:17
@mimarz mimarz force-pushed the fix-theme-entry-file branch from 62e5c71 to b9297ba Compare August 6, 2024 13:18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file supposed to be here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope!

@mimarz mimarz merged commit a9f0528 into next Aug 7, 2024
5 checks passed
@mimarz mimarz deleted the fix-theme-entry-file branch August 7, 2024 09:56
mimarz pushed a commit that referenced this pull request Aug 14, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Minor Changes

- feat: Convert to W3C design token format
([#2240](#2240))

### Patch Changes

- refactor: single CSS file for theme
([#2204](#2204))

- fix: Export correct types for color
([`e6325afa14e349698daf1082ba8844e80f46c5c0`](e6325af))

## @digdir/[email protected]

### Minor Changes

- Breadcrumbs: ✨ new component
([#2226](#2226))

- Badge: ✨ New component
([#2220](#2220))

### Patch Changes

- Modal: add missing ModalRoot export
([#2228](#2228))

- RovingFocus: add `orientation` to support for different arrow
directions, and add support home/end buttons
([#2206](#2206))

    -   Affects `ToggleGroup`, where up and down arrows can now be used
    -   Affects `ToggleGroup`, where home and end can now be used
    -   Affects `Tabs`, where home and end can now be used

- Accordion: Fix `defaultOpen` flicker on first render
([#2214](#2214))

- Tabs: Make arrow keys work in any direction
([#2223](#2223))

- Fixes so spacing is the same in checkbox and radio groups
([#2234](#2234))

- Divider: hide from screen readers
([#2232](#2232))

- Modal: remove `FloatingFocusManager`
([#2224](#2224))

- NativeSelect: add focus in `readOnly` state
([#2212](#2212))

## @digdir/[email protected]

### Patch Changes

- Fixes so spacing is the same in checkbox and radio groups
([#2234](#2234))

- Button: `text-align: inherit` when not in full width
([#2216](#2216))

- Breadcrumbs: ✨ new component
([#2226](#2226))

- Badge: ✨ New component
([#2220](#2220))

## @digdir/[email protected]

### Patch Changes

- refactor: single CSS file for theme
([#2204](#2204))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme files not working in some use-cases
2 participants