Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Drawer): new Drawer component #2203

Closed
wants to merge 2 commits into from

Conversation

Chlenix
Copy link
Contributor

@Chlenix Chlenix commented Aug 6, 2024

No description provided.

@Chlenix Chlenix requested review from mimarz and Barsnes as code owners August 6, 2024 08:29
Copy link

changeset-bot bot commented Aug 6, 2024

⚠️ No Changeset found

Latest commit: 0acf2c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mimarz
Copy link
Collaborator

mimarz commented Aug 6, 2024

Hey!

Thanks for making this PR.

I wish you would have contacted us before making this, as all new development is done against the next branch and we have done quite a lot of changes in regards to code structure for upcoming V1.

Good work here but some implementations is a bit incompatible with our current structure for React and CSS.

Notable differences:

  • We stopped using using css-modules in April. CSS now lives in packages/css and defined using a bem-inspired class syntax with file name same as component.
  • Completely new tokens and css variables. Example here
  • CSS variables are now prefixed with --ds instead of --fds.
  • We don't pass trigger element as prop. We use sub-component .Trigger.
  • We would prefer to use our own Modal or atleast a dialog element, instead of introducing a new dependency.
  • We now use biomejs for linting and formatting.

We also have an ongoing discussion about drawer here. I don't think we have delved to deep into the requirements and expected behaviour for this component yet 🤔

@mimarz
Copy link
Collaborator

mimarz commented Aug 29, 2024

Thanks for providing an example and features for a Drawer component.

We'll reference this suggested implementation and continue this discussion in #1819

@mimarz mimarz closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants