Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tokens): removed inverted color tokens that should not exist #1829

Merged
merged 4 commits into from
Apr 15, 2024
Merged

feat(tokens): removed inverted color tokens that should not exist #1829

merged 4 commits into from
Apr 15, 2024

Conversation

mrosvik
Copy link
Member

@mrosvik mrosvik commented Apr 15, 2024 •
edited by mimarz
Loading

BREAKING-CHANGE: Removed "inverted surface" tokens

  --fds-semantic-surface-on_inverted-default
  --fds-semantic-surface-on_inverted-hover
  --fds-semantic-surface-on_inverted-active
  --fds-semantic-surface-on_inverted-no_fill
  --fds-semantic-surface-on_inverted-no_fill-hover
  --fds-semantic-surface-on_inverted-no_fill-active
  --fds-semantic-border-on_inverted-default

Resolves #1830

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 15. Apr 2024 - 13:20 (Norwegian time)

🖥 Storefront 15. Apr 2024 - 13:21 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mrosvik mrosvik marked this pull request as ready for review April 15, 2024 09:55
@mrosvik mrosvik requested review from mimarz and Barsnes as code owners April 15, 2024 09:55
@mimarz
Copy link
Collaborator

mimarz commented Apr 15, 2024

Following css variables are removed:

  --fds-semantic-surface-on_inverted-default
  --fds-semantic-surface-on_inverted-hover
  --fds-semantic-surface-on_inverted-active
  --fds-semantic-surface-on_inverted-no_fill
  --fds-semantic-surface-on_inverted-no_fill-hover
  --fds-semantic-surface-on_inverted-no_fill-active
  --fds-semantic-border-on_inverted-default

mimarz
mimarz approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimarz mimarz merged commit ea9e670 into main Apr 15, 2024
6 checks passed
@mimarz mimarz deleted the tokens/remove-inverted-tokens branch April 15, 2024 11:23
mimarz added a commit that referenced this pull request Apr 18, 2024
@mimarz
Revert "feat(tokens): removed inverted color tokens that should not e…
21bd572 
…xist (#1829)"

This reverts commit ea9e670.
@mimarz mimarz restored the tokens/remove-inverted-tokens branch April 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove inverted tokens that should not exist anymore
2 participants
@mrosvik @mimarz