Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: new warning color tokens #1260

Merged
merged 4 commits into from
Jan 2, 2024
Merged

style: new warning color tokens #1260

merged 4 commits into from
Jan 2, 2024

Conversation

mrosvik
Copy link
Member

@mrosvik mrosvik commented Dec 20, 2023

No description provided.

@mrosvik mrosvik marked this pull request as ready for review December 20, 2023 11:42
Copy link
Contributor

github-actions bot commented Dec 20, 2023

Preview deployments for this pull request:

📖 Storybook 2. Jan 2024 - 09:09 (Norwegian time)

🖥 Storefront 2. Jan 2024 - 09:10 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mimarz
Copy link
Collaborator

mimarz commented Dec 20, 2023

hmm, didn't look like the deploy preview workflow got triggered here on changes from github actions generating new tokens @Thuneer

@Thunear
Copy link
Collaborator

Thunear commented Dec 20, 2023

This has to be investigated further. I Suspect that the Token Build action doesn't have the right permissions to be able to trigger the Preview Workflows. I created an issue.

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Do we have an issue to update relevant react components with these new tokens? @mrosvik @Febakke

@mimarz mimarz merged commit 79c4247 into main Jan 2, 2024
5 checks passed
@mimarz mimarz deleted the tokens/new-warning-colors branch January 2, 2024 08:26
@Febakke
Copy link
Member

Febakke commented Jan 2, 2024

LGTM 👍

Do we have an issue to update relevant react components with these new tokens? @mrosvik @Febakke

Related to the tag changes made in Figma: #1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants