Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): 🐛 Adjust sizing to match Textfield and other fixes according to Figma #1023

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Nov 1, 2023

fixes #797

  • Removed use of "component-mode" tokens used for sizing as they in the works to be changed. Uses same sizing value as other form components (Textfield, Textarea etc.)
    • small is now 38px instead of 36px
    • large is now 52px instead of 54px
  • Removed use of old letter-spacing token from altinn tokens
  • Fixed gaps according to Figma
  • Fixed paddings according to Figma
  • Fixed use of correct typography token according to Figma

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Preview deployments for this pull request:

📖 Storybook 1. Nov 2023 - 14:52 (CEST)

See all deployments at https://dev.designsystemet.no

@mimarz mimarz force-pushed the fix/button-sizing branch from 254ba13 to 380b8ea Compare November 1, 2023 11:47
@mimarz mimarz changed the title fix(Button): 🐛 Adjust sizing to match height of other form elements fix(Button): 🐛 Adjust sizing to match Textfield and other fixes according to Figma Nov 1, 2023
@mimarz mimarz marked this pull request as ready for review November 1, 2023 11:59
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mimarz mimarz merged commit a3252f9 into main Nov 1, 2023
3 checks passed
@mimarz mimarz deleted the fix/button-sizing branch November 1, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text fields and buttons should have the same height
2 participants