Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Box): New internal component #1001

Merged
merged 13 commits into from
Nov 2, 2023
Merged

feat(Box): New internal component #1001

merged 13 commits into from
Nov 2, 2023

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Oct 27, 2023 •
edited
Loading

Resolves #978

Taking inspiration from the links in the related issue, it will support shadow, border, background

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 2. Nov 2023 - 08:41 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review November 1, 2023 09:42
mimarz
mimarz approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a linting warning in stories, apart from that looks good! 👍

@Barsnes Barsnes merged commit 1651d4d into main Nov 2, 2023
3 checks passed
@Barsnes Barsnes deleted the feat/box branch November 2, 2023 07:37
@mimarz mimarz changed the title feat(Box): Make the component feat(Box): Add internal component Nov 8, 2023
@mimarz mimarz changed the title feat(Box): Add internal component feat(Box): New internal component Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@Thunear Thunear Awaiting requested review from Thunear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop a Paper/Box component
3 participants
@Barsnes @mimarz @Thunear