Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for cleaning up output folder in CLI #2809

Open
mimarz opened this issue Nov 20, 2024 · 0 comments
Open

Add option for cleaning up output folder in CLI #2809

mimarz opened this issue Nov 20, 2024 · 0 comments
Labels
cli @digdir/designsystemet

Comments

@mimarz
Copy link
Collaborator

mimarz commented Nov 20, 2024

We need to be able to clean up old tokens and generated theme css files to avoid bugs and conflicts.

If users want to rename color tokens and create new tokens, we get dangling design tokens with no connection. This will also be a use-case if they have used tokens build for css files. This can cause errors with duplicate definitions on selectors like :root for variables that no longer exist.

Suggestion:

  • By default, we delete the content of output folder, if files exist there, prompt user with warning for y/n about files being deleted to make way for new ones
  • Users can choose to suppress the warning by adding an argument, someting like --force or --unsafe
@mimarz mimarz converted this from a draft issue Nov 20, 2024
@mimarz mimarz added the cli @digdir/designsystemet label Nov 20, 2024
@mimarz mimarz added this to the V1 - Helhetlig tematisering milestone Nov 20, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli @digdir/designsystemet
Projects
Status: 📄 Todo
Development

No branches or pull requests

1 participant