Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing default colors for some components #2797

Closed
mimarz opened this issue Nov 20, 2024 · 2 comments
Closed

Missing default colors for some components #2797

mimarz opened this issue Nov 20, 2024 · 2 comments
Labels
css @digdir/designsystemet-css 🎨 theme-builder Everything related to our theme builder

Comments

@mimarz
Copy link
Collaborator

mimarz commented Nov 20, 2024

Test all components without having an immediate data-color present to test fallback/default colors.

I found it best to test this downstream in a clean app, as we have a lot of other defaults in storybook defined. It was very cumbersome to find and remove/disable all layers of coloring we had in storybook and other apps.

  • Checkbox is missing default color when checked
    Image
@mimarz mimarz converted this from a draft issue Nov 20, 2024
@mimarz mimarz added css @digdir/designsystemet-css 🎨 theme-builder Everything related to our theme builder labels Nov 20, 2024
@unekinn
Copy link
Contributor

unekinn commented Nov 21, 2024

Very interesting that this isn't an issue in Storybook / Chromatic. It probably means we need to rethink how these Storybook defaults work, in order for the visual tests to be reliable

@mimarz
Copy link
Collaborator Author

mimarz commented Nov 21, 2024

This was due to edge-case of generating and regenerating tokens, with old built css contaminating :root. #2809

@mimarz mimarz closed this as completed Nov 21, 2024
@github-project-automation github-project-automation bot moved this from 🔵 Inbox to ✅ Done in Team Design System Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css @digdir/designsystemet-css 🎨 theme-builder Everything related to our theme builder
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants