Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ErrorMessage to ValidationMessage #2444

Closed
2 tasks done
mimarz opened this issue Sep 18, 2024 · 2 comments
Closed
2 tasks done

Rename ErrorMessage to ValidationMessage #2444

mimarz opened this issue Sep 18, 2024 · 2 comments
Assignees
@Barsnes
Labels
☂️ epic Issues ready 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented Sep 18, 2024 •
edited by Febakke
Loading

Clearer intent of use so that it can support both invalid={true} and invalid={false} - making it easy to confirm that a input is valid as well - not only errors

Tasks
Beta Give feedback
@mimarz mimarz converted this from a draft issue Sep 18, 2024
@mimarz mimarz changed the title Rename ErrorMessage to ValidationMessage Suggest rename ErrorMessage to ValidationMessage Sep 18, 2024
@mimarz mimarz mentioned this issue Sep 18, 2024
Merged
@mimarz mimarz added 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react labels Sep 18, 2024
@mimarz
Copy link
Collaborator Author

mimarz commented Sep 18, 2024

We decided to do this in todays daily with team.

@mimarz mimarz added the ☂️ epic Issues ready label Sep 18, 2024
@mimarz mimarz moved this from 🔵 Inbox to ☂ Epics in Team Design System Sep 18, 2024
@mimarz mimarz changed the title Suggest rename ErrorMessage to ValidationMessage Rename ErrorMessage to ValidationMessage Sep 18, 2024
@mimarz mimarz changed the title Rename ErrorMessage to ValidationMessage Rename ErrorMessage to ValidationMessage Sep 19, 2024
This was referenced Sep 19, 2024
Closed
Open
@Barsnes Barsnes self-assigned this Sep 20, 2024
@Barsnes
Copy link
Member

Barsnes commented Sep 20, 2024

in progress for react

@Barsnes Barsnes mentioned this issue Sep 20, 2024
Merged
Barsnes added a commit that referenced this issue Sep 20, 2024
@Barsnes
feat: rename ErrorMessage to ValidationMessage (#2473)
f794c60 
part of #2444

This does not include the `invalid` prop mentioned, and does not rename
CSS vars, as this will be done in separate PRs
@github-project-automation github-project-automation bot moved this from ☂ Epics to ✅ Done in Team Design System Sep 20, 2024
This was referenced Oct 23, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Barsnes Barsnes

Labels
☂️ epic Issues ready 🎨 figma Everything related to changes in Figma react @digdir/designsystemet-react
Projects
Team Design System
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eirikbacker @mimarz @Barsnes