Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon to our ValidationMessage component #2300

Closed
3 tasks done
Febakke opened this issue Aug 21, 2024 · 2 comments
Closed
3 tasks done

Add icon to our ValidationMessage component #2300

Febakke opened this issue Aug 21, 2024 · 2 comments
Labels
☂️ epic Issues ready 🎨 figma Everything related to changes in Figma
Milestone
V1 - Helhetlig ko...

Comments

@Febakke
Copy link
Member

Febakke commented Aug 21, 2024 •
edited by mrosvik
Loading

We should follow our own guidelines. When working on the pattern for errormessages we concluded that you should use icon to use more than a color to differentiate from labels and other textelements.

Tasks
Beta Give feedback
  1. Are the icon we have available now good enough when in a small size? #2308
    🕵️ investigate
    Viveca24
  2. Icon on our ValidationMessage component #2309
    🎨 figma
    Viveca24
  3. Icon on our ValidationMessage component #2310
    react
@Febakke Febakke added the 🎨 figma Everything related to changes in Figma label Aug 21, 2024
@mrosvik mrosvik added the ☂️ epic Issues ready label Aug 22, 2024
@eirikbacker eirikbacker changed the title Add icon to our error message component Add icon to our ErrorMessage component Sep 18, 2024
@mimarz
Copy link
Collaborator

mimarz commented Sep 19, 2024

This needs to be done after 2444

@mrosvik mrosvik changed the title Add icon to our ErrorMessage component Add icon to our ValidationMessage component Sep 19, 2024
@Barsnes
Copy link
Member

Barsnes commented Oct 14, 2024

closing this as completed

@Barsnes Barsnes closed this as completed Oct 14, 2024
@github-project-automation github-project-automation bot moved this from ☂ Epics to ✅ Done in Team Design System Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☂️ epic Issues ready 🎨 figma Everything related to changes in Figma
Projects
Team Design System
Status: ✅ Done
Milestone
V1 - Helhetlig komponentbibliotek
Development

No branches or pull requests
4 participants
@mimarz @mrosvik @Barsnes @Febakke