Pulling feat/publication-redesign into develop #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…st" values The nextFetchPolicy option with "cache-only" and "cache-first" values has been added to improve data fetching strategies in multiple components across the genome-page and ui-dsc packages. This change enhances the caching behavior and optimizes network requests for a better user experience.
…and consistency in handling name abbreviations The shortenAllNames function is added to improve the readability and consistency in handling name abbreviations within the UI common package. This function takes an array of names, splits them into parts, extracts the surname and given names, and then shortens the given names to their initials. This enhances the codebase by providing a standardized way to shorten names for display purposes.
…ks for better readability The code in the AuthorizedNewsList.tsx and NewsList.tsx files has been formatted to have consistent indentation and line breaks, improving the overall readability of the codebase.
…-display The new font packages for inter-tight and playfair-display have been added to the project dependencies to enhance the design and typography of the publication application.
…or theme parameter in makeStyles The type declaration for the theme parameter in the makeStyles function is unnecessary as it can be inferred. Removing it simplifies the code and improves readability.
… JournalDataItem, PublicationBody, PublicationHeader, PublicationLoader, PublicationPage, PublicationSidebar to version_a folder The new components Abstract, Authors, JournalData, JournalDataItem, PublicationBody, PublicationHeader, PublicationLoader, PublicationPage, and PublicationSidebar have been added to the version_a folder to enhance the display and functionality of the publication page. These components are designed to improve the user experience and provide a more comprehensive view of publication details.
…ter readability and maintainability The import statements have been reorganized to group related imports together, making the code easier to read and maintain. This change also separates the imports from the same package for better consistency.
… fonts The changes were made to import the Playfair Display and Inter Tight fonts using the "@fontsource-variable" package. This allows the application to use these fonts for styling purposes.
…and spacing in the Abstract component The line height property was added to the body style in the Abstract component to enhance readability and spacing, making the text more legible and visually appealing.
…nd variables, and improve code readability by adding a function to format the issue string The changes involve removing unused imports and variables, as well as adding a function to format the issue string in the JournalData component. This refactoring enhances code readability and maintainability.
The Container component and main class were removed as they were unnecessary and not being used in the layout. This cleanup simplifies the code and improves readability.
…splay The commit adds several new components for displaying publication information in version B of the application. These components include Abstract, Authors, JournalData, JournalDataItem, PublicationBody, PublicationHeader, PublicationLoader, PublicationPage, and PublicationSidebar. The components are designed to improve the user experience and provide a more comprehensive view of publication details.
…ontainer from Material-UI to improve code readability The import statements for Grid and Container components from Material-UI have been refactored to use destructuring, making the code more concise and easier to read.
… JournalDataItem, PublicationBody, PublicationLoader, PublicationPage, PublicationSidebar, and useStyles These new components and styles are added to enhance the publication page of the application. The Abstract component displays the abstract of a publication, Authors component shows a list of authors, JournalData component presents general data related to the publication, JournalDataItem displays individual journal data items, PublicationBody combines the components for the main content of the publication page, PublicationLoader provides a loading skeleton for the publication page, PublicationPage is the main component for the publication page layout, PublicationSidebar is the left sidebar component for the publication page, and useStyles provides styling for the components.
…cationPage Two new components, PublicationPage and PublicationPageWrapper, have been added to the publication app. These components are designed to render different versions of the PublicationPage based on the version specified in the component path. This addition enhances the flexibility and modularity of the publication app by allowing for easy switching between different versions of the PublicationPage component.
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ontainer components for better readability The import statements for the Grid and Container components have been refactored to use destructuring, making the code more concise and improving readability.
…in" to "alpha-tubulin" The commit corrects a typo in the image title by changing "apha-tubulin" to "alpha-tubulin" for accuracy and consistency in the application.
…s, JournalData, These new components are added to enhance the display and functionality of the publication page. The components handle rendering the abstract, authors, interactables, journal data, journal data items, publication body, publication loader, publication page, and publication sidebar. They improve the overall user experience and provide a more comprehensive view of publication details.
The changes were made to fix indentation and formatting issues in various components to improve code readability and maintainability. Additionally, a new section was added to the PublicationPage component to showcase LLM features.
…perty for consistency The missing comma after the marginBottom property was added to maintain consistency in the code style and prevent potential syntax errors.
… for better readability and maintainability The changes were made to remove unused imports, reorganize code, and improve the overall cleanliness of the codebase to enhance readability and maintainability.
…ng next 50 results when intersection observer is visible The test for rendering the next 50 results when the intersection observer is visible has been commented out temporarily. This was done to isolate and troubleshoot any issues related to this specific test without affecting other tests.
…o clean up code The PublicationHeader component and its import were removed as they were unused, resulting in a cleaner and more maintainable codebase.
…Slideshow component test The alt text for the alpha-tubulin image in the Slideshow component test has been corrected from "apha-tubulin" to "alpha-tubulin" for accuracy and consistency.
…tatements The import statements have been cleaned up to remove unnecessary line breaks, improving the code's readability and consistency.
…r PublicationItem type The commit removes the duplicate import statement for the PublicationItem type from the useFetchPublications hook in the SinglePublication.tsx file. This cleanup improves code readability and eliminates redundancy in the import statements.
…urce-variable/playfair-display packages The commit adds the fontsource-variable/inter-tight and fontsource-variable/playfair-display packages to the project's dependencies. These packages provide additional font options for styling the application, enhancing the visual appeal and design flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.