Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-generated Pull Request for fix/content-api-attributes #14

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Auto-generated Pull Request for fix/content-api-attributes #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04f90e8
feat(content.proto): add slug field to NewContentAttributes message
cybersiddhu Oct 30, 2023
6a886ba
docs(README.md): improve readability and clarify development process
cybersiddhu Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,11 @@ In general, every API has its own directory with matching proto packages. The

## Development

This project has been designed to be automated by GitHub Actions. To make changes,
create a new branch and push your changes. This will automatically create a pull
request then run `buf lint` to verify your changes. If everything is fine, it will
generate updated Go code and open a PR in the [go-genproto](https://github.com/dictyBase/go-genproto)
This project has been designed to be automated by GitHub Actions. To make
changes, create a new branch and push your changes. This will automatically
create a pull request then run `buf lint` to verify your changes. If everything
is fine, merge it to the master branch and it will generate updated Go code and
open a PR in the [go-genproto](https://github.com/dictyBase/go-genproto)
repository where it will need to be manually reviewed.

**Note: if making any updates to the `buf.gen.yaml` file, you need to run `buf beta mod update`
Expand Down
2 changes: 2 additions & 0 deletions dictybase/content/content.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ message NewContentAttributes {
// namespace for the page, it is prepended to the
// name to generate an unique slug.
string namespace = 4 [(validator.field) = {string_not_empty: true}];
// page slug. Look here https://en.wikipedia.org/wiki/Semantic_URL#Slug to know about slug
string slug = 5 [(validator.field) = {string_not_empty: true}];
}

// Definition for storing new content
Expand Down
Loading