Nostr Key Decoding #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustchain64
approved these changes
Mar 2, 2024
| @@ -84,7 +84,7 @@ pub fn decode( | |||
| padding: u32, | |||
| format: u8, | |||
| ) -> Result<Vec<u8>, CarbonadoError> { | |||
| let format = Format::try_from(format)?; | |||
| let format = Format::from(format); | |||
There was a problem hiding this comment.
Interesting you dropped "try_from" to "from", isn't that a downgrade.
Just wondering the logic for this.
There was a problem hiding this comment.
No, that's better. The library we're using can guarantee infallibility at the type level.
| @@ -1,7 +1,7 @@ | |||
| use std::sync::Once; | |||
|
|
|||
| use bao::Hash; | |||
| use bech32::{decode, encode, FromBase32, ToBase32, Variant}; | |||
| use bech32::{decode, encode, Bech32m, Hrp}; | |||
There was a problem hiding this comment.
I will need to review the bao::Hask to understand the minus of "FromBase32, etc.and what is Hrp"
There was a problem hiding this comment.
This is for bech32 encoding. HRP stands for Human Readable Part. You can read more in the BIP:
https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.