Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Change column names in intermediate CSVs. #133

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Conversation

ctb
Copy link
Member

@ctb ctb commented Jan 11, 2022

Note: PR into #130

Change ncbi_tax_name to display_name and acc to ident throughout.

@ctb ctb changed the base branch from latest to allow/private January 11, 2022 22:13
@ctb ctb merged commit 79626e5 into allow/private Jan 11, 2022
@ctb ctb deleted the change/columns branch January 11, 2022 22:16
ctb added a commit that referenced this pull request Jan 17, 2022
)

* rename rule to sourmash_prefetch_wc

* start using {outdir}/genomes/

* swizzle up config to allowprivate_databases and genbank_databases, etc.

* more progress: copying private genomes around

* combine listing private and genbank genomes - seems to work\!

* simplify the ListGenomes stuff

* it's aliiiiiiiive

* remove genbank accession requirement

* remove genbank from most filenames, rules

* rename minimap to mapping; add clean_gather

* updated to properly (?) use checkpoints throughout

* tests pass locally

* fix typo

* add the beginnings of testing for private databases

* getting started

* update all the things

* [MRG] Change column names in intermediate CSVs. (#133)

* change column names

* remove old notebooks

* fix mistake

* comments etc.

* remove glob pattern, configure genbank_cache

* remove 'process' command

* check for old config file params

* add important comment

* actually remove 'process'

* check for 'database_taxonomy' instead of 'taxonomies'

* add trailing / in Makefile

* add default taxonomies file to system.conf

* fix test files

* fix conf-private.yml

* start of doc/ subdirectory

* initial commit

* add badge

* compleat first draft

* minor corrections

* spell check

* add picklists into the config (#136)

* fix 'taxonomies' in test config; check that it's a list

* add comment

* swipe from #97

* swipe getting started from #97

* update!

* Apply suggestions from Taylor's docs review

Co-authored-by: Taylor Reiter <[email protected]>

* more update in re taylor's suggestions

* more more update

* even more update

* more update

* more update

* fix help output for CLI

* configure mkdocs

* clean it out

* update gitignore

* add some figures

* upd

* more figure adjustment

* add badges

* simplify to single sourmash_dtabases; use 'local' instead of 'private'

* update to 'local' instead of 'private'

* fix extra backquote

* more fix?

* fix formatting

* add tax test

* add test for picklist

* switch SRR5950647_subset over to use local_databses_info 🎉

* cleanup & commenting

* add missing file

Co-authored-by: HackMD <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant