Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit indices #198

Closed
wants to merge 3 commits into from
Closed

Hit indices #198

wants to merge 3 commits into from

Conversation

dermen
Copy link
Contributor

@dermen dermen commented Mar 14, 2024

When you know the hits in an XTC stream, and you only want to reprocess those hits, skip reading the other data

This seems to work well, only it fails for multi-run datasources. And by fails, I mean, the indexing gets screwed up. Possibly a psana issue

@dermen dermen requested review from phyy-nx and dwpaley March 14, 2024 14:09
@graeme-winter
Copy link
Contributor

@dermen you want to make this against #cctbx/dxtbx

@dermen
Copy link
Contributor Author

dermen commented Mar 14, 2024

@graeme-winter , weird, I dont even know how that happened. This is what I saw locally when I pushed the last commit

To github.com:cctbx/dxtbx.git
   c5144ff7..724eb8bb  hit_indices -> hit_indices
Branch 'hit_indices' set up to track remote branch 'hit_indices' from 'origin'.

Could it be because I have export DIALS_WITHOUT_PRECOMMITS=1 (cant install precommit tools on my miniforge build for whatever reason)

@graeme-winter
Copy link
Contributor

@dermen not your fault 🙂

The default is annoyingly wrong

@dermen dermen removed request for phyy-nx and dwpaley March 14, 2024 14:47
@dermen dermen closed this Mar 14, 2024
@dermen dermen mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants