Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for repository functions #24

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Conversation

dhth
Copy link
Owner

@dhth dhth commented Sep 9, 2024

A first attempt at setting up testing for persistence functions.

internal/persistence/queries_test.go Outdated Show resolved Hide resolved
internal/persistence/queries_test.go Outdated Show resolved Hide resolved
internal/persistence/queries_test.go Outdated Show resolved Hide resolved
internal/persistence/queries_test.go Outdated Show resolved Hide resolved
@dhth dhth marked this pull request as ready for review September 10, 2024 21:44
internal/persistence/queries.go Outdated Show resolved Hide resolved
Copy link

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

A minor remark, but I'm fine with your PR

internal/persistence/queries_test.go Outdated Show resolved Hide resolved
@ccoVeille
Copy link

I hope you enjoyed my feedbacks

@dhth
Copy link
Owner Author

dhth commented Sep 11, 2024

I hope you enjoyed my feedbacks

Definitely, thanks for the reviews :)

I left a sorta high level question regarding types here; any help would be appreciated :)

@dhth dhth merged commit 9c638be into main Sep 11, 2024
6 checks passed
@dhth dhth deleted the add-persistence-tests branch September 11, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants