-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requiredness of name attribute in ObjectMeta #85
Conversation
It is only required for top-level objects . (E.g. `Deployment`, `Pod`, `DaemonSet`) but it is Optional when it is part of a compond object (e.g. `PodTemplateSpec` inside a `Deployment` or `DaemonSet`) See #8 (comment) and #84 (comment)
We could do something smart here: Generate However I think just making it optional is maybe the better option here. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. The type safety doesn't have to be perfect. For example, if we really went all in on type safety we'd have to fix fields like updateStrategy.type
to be enums that enumerated all possible valid values. I think the right thing to do is to build a higher-level library on top of this one that provides stronger guarantees and keep the scope of this library to just auto-generating raw Dhall types
While I'm at it I should probably fix the examples to contain a selector |
@arianvp You missed the README.md :) |
sorry this kind of got side-tracked =) i'll have another look at this soon |
Any updates for this PR? |
I can open up a new pull request against |
Alright, I have a new pull request out that supersedes this one: #115 |
It is only required for top-level objects . (E.g.
Deployment
,Pod
,DaemonSet
) but it is Optional when it is part of a compond object(e.g.
PodTemplateSpec
inside aDeployment
orDaemonSet
)See #8 (comment)
and #84 (comment)