Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): refactor RSS feed encoding, structure, and include thumbn… #1242

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

dgrebb
Copy link
Owner

@dgrebb dgrebb commented Feb 17, 2024

…ail and hero (#1241)

Describe your changes

Adds image hero and thumbnail, restructures RSS elements, and encodes special characters.

Issue ticket number and link

Closes: #1241

Checklist before requesting a review

  • Code linting succeeds
  • Visual Regression is Passing
  • I have performed a self-review of my code
  • Do we need to implement analytics?
  • Have you tested with JavaScript off?

.join('\n')}
</feed>`;
return `<item>
<title>${post.attributes.title.replace('&', '&amp;')}</title>

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of '&'.
@dgrebb dgrebb merged commit eb52fde into develop Feb 17, 2024
8 of 9 checks passed
@dgrebb dgrebb deleted the fix/1241-RSS-feed-character-encoding branch February 17, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐞 [BUG]: FE - RSS Feed broken by Ampersand
1 participant