Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(front): remove content container background #1203

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

dgrebb
Copy link
Owner

@dgrebb dgrebb commented Jan 28, 2024

Describe your changes

There was inconsistency across pages. Trying out zero background across all pages — this may have a performance benefit as well.

  • Code linting succeeds
  • Visual Regression is Passing
  • I have performed a self-review of my code
  • Do we need to implement analytics?
  • Have you tested with JavaScript off?

this was inconsistent. trying out zero background across all pages — this may have a performance benefit as well.
@dgrebb dgrebb merged commit 2b4937d into develop Jan 28, 2024
8 checks passed
@dgrebb dgrebb deleted the feat/backgroundless-content branch January 28, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant