chore(ci): updates lighthouse and configuration thereof

dgrebb · Oct 18, 2023 · d5ea0b1 · d5ea0b1
1 parent 8d69bc6
commit d5ea0b1
Show file tree

Hide file tree

Showing 26 changed files with 263 additions and 135 deletions.
diff --git a/.github/workflows/bd-fe.yml b/.github/workflows/bd-fe.yml
@@ -148,7 +148,7 @@ jobs:
       - name: ↕ Sync S3
         uses: jakejarvis/s3-sync-action@master
         with:
-          args: --acl public-read --follow-symlinks --delete --cache-control max-age=2853213,public
+          args: --acl public-read --follow-symlinks --delete --cache-control max-age=8380800,public
         env:
           AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }}
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}

diff --git a/.github/workflows/test-backstop-refs.yml b/.github/workflows/test-backstop-refs.yml
@@ -42,7 +42,7 @@ jobs:
         run: cd _ci/backstop && npm ci
 
       - name: 🔥 Warm Cache
-        run: ./_ci/_utils/warmup.sh
+        run: ./_ci/_utils/warmup.sh ${{ github.ref_name == 'main' && 'prd' || 'stg' }}
 
       - name: 📸 Capturing References
         id: backstop

diff --git a/.github/workflows/test-backstop.yml b/.github/workflows/test-backstop.yml
@@ -65,7 +65,7 @@ jobs:
         run: cd _ci/backstop && npm ci && npx playwright install --with-deps
 
       - name: 🔥 Warmup Cache
-        run: ./_ci/_utils/warmup.sh
+        run: ./_ci/_utils/warmup.sh ${{ github.ref_name == 'main' && 'prd' || 'stg' }}
 
       - name: 👀 Testing Bitmaps
         id: backstop

diff --git a/.github/workflows/test-lighthouse.yml b/.github/workflows/test-lighthouse.yml
@@ -55,10 +55,11 @@ jobs:
 
       - name: 🌤️ Warmup CloudFront Cache
         run: |
-          _ci/_utils/warmup.sh
+          _ci/_utils/warmup.sh ${{ github.ref_name == 'main' && 'prd' || 'stg' }}
 
       - name: 🔦 Lighthouse
         id: lighthouse
+        continue-on-error: true
         run: |
           cd _ci/perf/lighthouse
           urls="${{ vars.LIGHTHOUSE_URLS }}"

diff --git a/.github/workflows/test-psi.yml b/.github/workflows/test-psi.yml
@@ -37,7 +37,7 @@ jobs:
 
       - name: 🌤️ Warmup CloudFront Cache
         run: |
-          _ci/_utils/warmup.sh
+          _ci/_utils/warmup.sh ${{ github.ref_name == 'main' && 'prd' || 'stg' }}
 
       - name: PageSpeed Insights Mobile
         id: psim

diff --git a/_ci/_utils/warmup.sh b/_ci/_utils/warmup.sh
@@ -38,7 +38,9 @@ warmUp() {
     # If there are particular subdirectories in your sitemap that you do not wish to parse
     # (i.e. because they cannot be cached), you can use the following regex:
     # grep -oP "https?://$1\/((?!subdirectory))[^<]*"
-    wget --user-agent="$USERAGENT" -q "https://$1/sitemap.xml" --output-document - | egrep -o "https?://$1[^<]+" | wget -i -
+    # wget --user-agent="$USERAGENT" -q "https://$1/sitemap.xml" --output-document - | egrep -o "https?://$1[^<]+" | wget -i -
+    #  NOTE: updated to include automation querystring
+    wget --user-agent="$USERAGENT" -q "https://$1/sitemap.xml" --output-document - | egrep -o "https?://$1[^<]+" | sed 's/$/\?roboto/' | wget -i -
 }
 
 if [ $# -eq 0 ]; then

diff --git a/...ackstop/bd/bitmaps_reference/gh-stg/GithubSTG_Cats_-_Mobile_0_document_0_xs.png b/...ackstop/bd/bitmaps_reference/gh-stg/GithubSTG_Cats_-_Mobile_0_document_0_xs.png
diff --git a/...ackstop/bd/bitmaps_reference/gh-stg/GithubSTG_Cats_-_Mobile_0_document_1_sm.png b/...ackstop/bd/bitmaps_reference/gh-stg/GithubSTG_Cats_-_Mobile_0_document_1_sm.png
diff --git a/...tmaps_reference/local/Local_Cats_-_Active_Thoughts_Category_0_viewport_1_sm.png b/...tmaps_reference/local/Local_Cats_-_Active_Thoughts_Category_0_viewport_1_sm.png
diff --git a/_ci/backstop/bd/bitmaps_reference/local/Local_Cats_-_Mobile_0_document_0_xs.png b/_ci/backstop/bd/bitmaps_reference/local/Local_Cats_-_Mobile_0_document_0_xs.png
diff --git a/_ci/backstop/bd/bitmaps_reference/local/Local_Cats_-_Mobile_0_document_1_sm.png b/_ci/backstop/bd/bitmaps_reference/local/Local_Cats_-_Mobile_0_document_1_sm.png
diff --git a/...bd/bitmaps_reference/local/Local_Post_-_Navigate_From_Posts_0_document_3_lg.png b/...bd/bitmaps_reference/local/Local_Post_-_Navigate_From_Posts_0_document_3_lg.png
diff --git a/...bd/bitmaps_reference/local/Local_Post_-_Navigate_From_Posts_0_document_4_xl.png b/...bd/bitmaps_reference/local/Local_Post_-_Navigate_From_Posts_0_document_4_xl.png
diff --git a/...d/bitmaps_reference/local/Local_Post_-_Navigate_From_Posts_0_document_5_2xl.png b/...d/bitmaps_reference/local/Local_Post_-_Navigate_From_Posts_0_document_5_2xl.png
diff --git a/...perf/lighthouse/.lighthouserc.desktop.cjs → _ci/perf/lighthouse/.lighthouserc.desktop.js b/...perf/lighthouse/.lighthouserc.desktop.cjs → _ci/perf/lighthouse/.lighthouserc.desktop.js
@@ -1,4 +1,4 @@
-module.exports = {
+const config = {
   extends: "lighthouse:default",
   settings: {
     psiToken: process.env.PSI_APIKEY,
@@ -18,7 +18,15 @@ module.exports = {
       deviceScaleFactor: 1,
       disabled: false,
     },
+    skipAudits: [
+      // Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
+      "uses-http2",
+      // There are always bf-cache failures when testing in headless. Reenable when headless can give us realistic bf-cache insights.
+      "bf-cache",
+    ],
     emulatedUserAgent:
       "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36",
   },
 };
+
+export default config;
diff --git a/_ci/perf/lighthouse/.lighthouserc.mobile.cjs b/_ci/perf/lighthouse/.lighthouserc.mobile.cjs
diff --git a/_ci/perf/lighthouse/.lighthouserc.mobile.js b/_ci/perf/lighthouse/.lighthouserc.mobile.js
@@ -0,0 +1,15 @@
+const config = {
+  extends: "lighthouse:default",
+  settings: {
+    maxWaitForFcp: 15 * 1000,
+    maxWaitForLoad: 35 * 1000,
+    skipAudits: [
+      // Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
+      "uses-http2",
+      // There are always bf-cache failures when testing in headless. Reenable when headless can give us realistic bf-cache insights.
+      "bf-cache",
+    ],
+  },
+};
+
+export default config;