Fix CMake Install Path #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftraple
reviewed
Mar 29, 2022
| @@ -234,7 +234,7 @@ endif() | |||
|
|
|||
| set(BINARY_INST_DESTINATION "bin") | |||
| set(RESOURCE_INST_DESTINATION "share/shadered") | |||
| install(PROGRAMS bin/SHADERed DESTINATION "${BINARY_INST_DESTINATION}" RENAME shadered) | |||
| install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/bin/SHADERed DESTINATION "${BINARY_INST_DESTINATION}" RENAME shadered) | |||
There was a problem hiding this comment.
This should be done to all the hard-coded paths, e.g:
install(DIRECTORY bin/data bin/templates bin/themes bin/plugins DESTINATION "${RESOURCE_INST_DESTINATION}")
if (UNIX AND NOT APPLE)
# install XDG desktop file and icon on Linux/BSD
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/Misc/Linux/org.shadered.SHADERed.desktop DESTINATION "share/applications" RENAME shadered.desktop)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/Misc/Icon/icon.svg DESTINATION "share/pixmaps" RENAME shadered.svg)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/bin/icon_32x32.png DESTINATION "share/icons/hicolor/32x32/apps" RENAME shadered.png)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/bin/icon_64x64.png DESTINATION "share/icons/hicolor/64x64/apps" RENAME shadered.png)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/bin/icon_128x128.png DESTINATION "share/icons/hicolor/128x128/apps" RENAME shadered.png)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/bin/icon_256x256.png DESTINATION "share/icons/hicolor/256x256/apps" RENAME shadered.png)
endif()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building this with a custom binary output path breaks with file not found the usage of this variable fixes that.
example for a custom output path is the build system on nixos (NixOS/nixpkgs#143915)