Fix Add Motor Operator #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a link had to be the active object for the operator to be enabled. Now a link has to be in the selection and the operator will be applied to all links in the selection
Add feedback
hwiedPro
requested changes
Jun 13, 2024
phobos/blender/operators/editing.py
Outdated
| @@ -1758,7 +1758,7 @@ def poll(cls, context): | |||
|
|
|||
| class AddMotorOperator(Operator): | |||
| """Add a motor to the selected joint. | |||
| It is possible to add motors to multiple joints at the same time""" | |||
| It is possible to add motors to multiple joints at the same time""" | |||
There was a problem hiding this comment.
This indentation change is faulty.
There was a problem hiding this comment.
I added this because the indentation is visible in the tooltip for the operator. With the indentation the tooltip looks like this:
After the change it looks like this:
There was a problem hiding this comment.
What happens if you add a line break before the closing """ with the correct level of indentation? Maybe this helps blender to find the correct line break. How is it done with the other operators?
Like this:
class AddMotorOperator(Operator):
"""Add a motor to the selected joint.
It is possible to add motors to multiple joints at the same time
"""There was a problem hiding this comment.
Most of them are all one liners except AddSensorOperator. How does the tooltip look there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Issue #212
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: