CI bug fix #336
Open
CI bug fix #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 9, 2023 17:08
hwiedPro
reviewed
Feb 7, 2024
hwiedPro
reviewed
Feb 13, 2024
hwiedPro
reviewed
Feb 13, 2024
| @@ -258,7 +258,8 @@ def export_xml(self, outputdir=None, format="urdf", filename=None, float_fmt_dic | |||
|
|
|||
| def export_smurf(self, outputdir=None, outputfile=None, robotfile=None, | |||
| check_submechs=True, with_submodel_defs=False, | |||
| with_meshes=True, mesh_format=None, additional_meshes=None, rel_mesh_pathes=None): | |||
| with_meshes=True, mesh_format=None, additional_meshes=None, rel_mesh_pathes=None, | |||
| submodels=None): | |||
| """ Export self and all annotations inside a given folder with structure | |||
There was a problem hiding this comment.
This seems to be a new feature, could you please open a separate PR for this?
hwiedPro
reviewed
Feb 13, 2024
|
Hi @trampler , The selectable submodels for the export_smurf seems a cool new feature, ould you open a separate PR for those? The issue with the include_unstopped_branches, didn't yet occur for me. Do you have an example where this leads to problems? Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include_unstopped_branchesis inconsistent and results in a failed assertion with submodels