Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont run if triggered by merge queue #10

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

cgundy
Copy link
Member

@cgundy cgundy commented Sep 21, 2023

Using merge_group leads to strange behavior, as the workflow isn't able to recognize who the author is when run on a merge queue, therefore labeling the person as an external contributor. However, we still need the merge_group to trigger the workflow, otherwise the ruleset will fail. Therefore we trigger the workflow but still skip it from being executed.

@cgundy cgundy marked this pull request as ready for review September 21, 2023 18:45
@cgundy cgundy requested a review from a team as a code owner September 21, 2023 18:45
@levsha
Copy link
Contributor

levsha commented Oct 2, 2023

https://github.com/orgs/community/discussions/58673 is probably the cause

@cgundy cgundy changed the title dont run on merge_group dont run if triggered by merge queue Oct 2, 2023
@cgundy
Copy link
Member Author

cgundy commented Oct 2, 2023

https://github.com/orgs/community/discussions/58673 is probably the cause

Ah - thanks a lot for that! I made a small update based on that post.

@cgundy cgundy requested a review from levsha October 2, 2023 08:27
@cgundy cgundy merged commit 8f978a2 into main Oct 2, 2023
4 checks passed
@cgundy cgundy deleted the disable-workflow-for-merge-group branch October 2, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants