perf(station): make concurrent balance queries more efficient #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keplervital
reviewed
Nov 25, 2024
| fn from(balance: &AccountBalance) -> Self { | ||
| let balance_age_ms = crate::core::ic_cdk::api::time() | ||
| .saturating_sub(balance.last_modification_timestamp) | ||
| / 1000; |
There was a problem hiding this comment.
time get's back the time in nanoseconds, to get the miliseconds you need to divide by 1_000_000
keplervital
reviewed
Nov 25, 2024
| CallerGuard::new( | ||
| state.clone(), | ||
| balance_update_guard_key, | ||
| Some(time() + Duration::from_secs(60).as_nanos() as u64), |
There was a problem hiding this comment.
maybe better to increase this to 5min in case the subnet would be with high load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment concurrent calls to fetch the balances of the assets of an account result in all of them fetching the balances with inter canister calls.
If an account asset balance is getting queried concurrent calls should not result in additional balance queries, but those should return the last balance value.