-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): UI for external canister monitoring setup #419
Merged
jedna
merged 15 commits into
pen-331-canfund-external-canisters
from
pen-361-monitoring-ui
Nov 22, 2024
Merged
feat(wallet): UI for external canister monitoring setup #419
jedna
merged 15 commits into
pen-331-canfund-external-canisters
from
pen-361-monitoring-ui
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-361-monitoring-ui
…-361-monitoring-ui
…-361-monitoring-ui
…-361-monitoring-ui # Conflicts: # apps/wallet/src/generated/station/station.did.js
…-361-monitoring-ui
jedna
changed the title
feat(external-canister): UI for external canister monitoring setup
feat(wallet): UI for external canister monitoring setup
Nov 21, 2024
keplervital
reviewed
Nov 21, 2024
keplervital
reviewed
Nov 21, 2024
apps/wallet/src/components/external-canisters/CanisterMonitorDialog.spec.ts
Outdated
Show resolved
Hide resolved
…ialog.spec.ts Co-authored-by: Kepler Vital <[email protected]>
``` Benchmark: list_external_canisters_with_all_statuses total: instructions: 231.11 M (regressed by 9.11%) heap_increase: 0 pages (no change) stable_memory_increase: 0 pages (no change) ```
jedna
merged commit Nov 22, 2024
1fda675
into
pen-331-canfund-external-canisters
16 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.