Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dfx-orbit): Implement station file option #406

Merged
merged 3 commits into from
Oct 28, 2024
Merged

feat(dfx-orbit): Implement station file option #406

merged 3 commits into from
Oct 28, 2024

Conversation

Sawchord
Copy link
Collaborator

This PR enables to specify a --station-file, to load the station configuration from, rather than using station files stored via dfx-orbit station add.

The rationale is, that this makes using dfx-orbit easier from CI, and to distribute station files with repositories.

@Sawchord Sawchord marked this pull request as ready for review October 25, 2024 15:11
@Sawchord Sawchord requested a review from a team as a code owner October 25, 2024 15:11
@Sawchord Sawchord changed the title feat(dfx-orbit) : Implement station file option feat(dfx-orbit): Implement station file option Oct 25, 2024
Copy link
Member

@keplervital keplervital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sawchord Sawchord enabled auto-merge (squash) October 28, 2024 15:08
@Sawchord Sawchord merged commit 3a4cd2c into main Oct 28, 2024
22 checks passed
@Sawchord Sawchord deleted the leon/ci_opt branch October 28, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants