feat(station): external canister input to accept opt policies and permissions by type #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keplervital
changed the title
mraszyk
reviewed
Sep 30, 2024
Co-authored-by: mraszyk <[email protected]>
mraszyk
reviewed
Sep 30, 2024
mraszyk
reviewed
Sep 30, 2024
mraszyk
reviewed
Sep 30, 2024
mraszyk
reviewed
Sep 30, 2024
This comment was marked as resolved.
This comment was marked as resolved.
mraszyk
reviewed
Sep 30, 2024
This comment was marked as resolved.
This comment was marked as resolved.
mraszyk
reviewed
Oct 1, 2024
core/station/impl/src/repositories/indexes/request_policy_resource_index.rs
Show resolved
Hide resolved
mraszyk
reviewed
Oct 1, 2024
core/station/impl/src/repositories/indexes/request_policy_resource_index.rs
Outdated
Show resolved
Hide resolved
mraszyk
reviewed
Oct 1, 2024
mraszyk
reviewed
Oct 1, 2024
mraszyk
reviewed
Oct 1, 2024
mraszyk
reviewed
Oct 1, 2024
mraszyk
reviewed
Oct 1, 2024
mraszyk
reviewed
Oct 1, 2024
mraszyk
reviewed
Oct 1, 2024
mraszyk
reviewed
Oct 2, 2024
mraszyk
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the existing API it was not possible to optionally only update the ExternalCanister change or call request policies, we always had to provide both, same with the permissions for read, change, call. This PR updates that and marks the individual policy and permission types as optional.