Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry request status #22

Merged
merged 8 commits into from
Jul 30, 2024
Merged

feat: retry request status #22

merged 8 commits into from
Jul 30, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

We need a function that repeatitively send ICRC29 status request from the relying party to the wallet with a timeout.

Copy link

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few comments.

src/handlers/wallet.handlers.ts Show resolved Hide resolved
src/handlers/wallet.handlers.spec.ts Show resolved Hide resolved
src/handlers/wallet.handlers.spec.ts Outdated Show resolved Hide resolved
Copy link

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterpeterparker peterpeterparker merged commit b541f1e into main Jul 30, 2024
7 checks passed
@peterpeterparker peterpeterparker deleted the feat/retry-request branch July 30, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants